|
|
От: |
Sinclair
|
https://github.com/evilguest/ |
| Дата: | 01.02.26 11:35 | ||
| Оценка: | |||
PD>вполне умели делать статические анализаторы и без всякого ИИ. Тот же PVS-Studio, например.PD>Codex Review
PD>Here are some automated review suggestions for this pull request
?When a job reaches a terminal status, this block only clears fields and cancels the ticker, but it leaves the m.beats[jobID] entry allocated. Because every job that emits any event creates a heartbeatState (see the earlier m.beats[jobID] = state), the map grows monotonically and will retain one entry per completed job for the lifetime of the engine. Over time this becomes a memory leak and increases lock contention on m.mu. Consider deleting the map entry when the status is succeeded/failed (or when canceling) so completed jobs don’t accumulate.